[RELEASE-v0.26] Remove myself from OWNERS #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusthoemmes
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ReToCode
pushed a commit
to ReToCode/eventing-kafka
that referenced
this pull request
Jan 3, 2023
* Channel upgrade tests structure and smoke test * Code reformat * Executing shell scripts to install eventing core * Eventing Core installs well * Fix add_trap function * Install latest release and HEAD of consolidated channel * Install channel from release works * Format code * Default a KafkaChannel in upgrade tests * Continual tests * Update configmap instead of patch * Removal of strict mode from e2e-common as it fails current code :-( * Reformatting * Invoke upgrade tests while testing consolidated * Proper invocation od e2e-upgrade-tests * Move strict mode after souring the library * Move strict mode lower * Reference the eventing-core wathola test images * Run post-scripts * Move strict mode lower * Remove strict mode from scripts :-/ * Raise unavailable period to report to 40 sec * Shorter name of main test method * Commenting out run_postinstall_jobs to pass mt-source job See reported issue: knative-extensions#495 * Removing temporal invocation of upgrade tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I arguably shouldn't have been on here anyway, so might as well starting the cleanup early.
/assign @devguyio @matzew @pierDipi